Update the docker-compose.yml file#1030
Open
m88youngling wants to merge 7 commits intoLBPUnion:mainfrom
Open
Conversation
Uhhh I hope this change adds the ability for the api to report the number of rooms per platform.
Changed the api image source based on suggestions from Slendy
Rolled back my failed attempt to add rooms per platform to the statistics endpoint.
Added Hyphen-tilda's suggested changes to add Hong Kong IDs
Contributor
Qodana for .NET191 new problems were found
☁️ View the detailed Qodana report Detected 72 dependenciesThird-party software listThis page lists the third-party software dependencies used in ProjectLighthouse Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the docker-compose.yml file to replace currently nonfunctional Docker images. You might notice something weird in this pull request, I wasn't sure how to roll back the commit that improperly modified the StatisticsEndpoints.cs. So, I corrected my initial change by creating a new commit that removed the additional line that I previously added. This should make it identical to the original StatisticsEndpoints.cs. I think it would be better though to not merge these commits at all for the sake of cleanliness. If anyone has any advice let me know.
Closes #1026