Erik/harmonicscomments #427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakufaku
requested changes
Feb 8, 2026
Collaborator
fakufaku
left a comment
fakufaku
left a comment
There was a problem hiding this comment.
Thanks, this is great! I just found a couple typos in the docstrings. It would be great if you can fix them, and then I can merge it.
| mask = m != 0 | ||
| if np.any(mask): | ||
| y_real[mask] *= np.sqrt(2) * np.array([-1.0]) ** m[mask] | ||
| # In the formular, for m<0, |m| is used. We consider this by the use of the constraint. |
Collaborator
There was a problem hiding this comment.
Small typo: formular -> formula
|
|
||
| Real Spherical Harmonics are used in the `Ambisonic file format | ||
| <https://en.wikipedia.org/wiki/Ambisonic_data_exchange_formats>`_, | ||
| which can be uses to represents and restore a sound field at a given point. |
Collaborator
There was a problem hiding this comment.
Typo:
uses -> used
represents -> represent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request builds upon #422 .