Change number field signature display from [r1, r2] to (r1, r2)#6841
Open
Change number field signature display from [r1, r2] to (r1, r2)#6841
Conversation
Co-authored-by: edgarcosta <322822+edgarcosta@users.noreply.github.com>
Co-authored-by: edgarcosta <322822+edgarcosta@users.noreply.github.com>
Co-authored-by: edgarcosta <322822+edgarcosta@users.noreply.github.com>
Co-authored-by: edgarcosta <322822+edgarcosta@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix signature display for number fields to use brackets
Change number field signature display from [r1, r2] to (r1, r2)
Jan 29, 2026
Member
|
I think @jwj61 should review this before it is merged |
Member
|
Will look at when tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Number field signatures are currently displayed with square brackets but should use parentheses to match standard mathematical notation.
Changes
web_number_field.py: Added
signature_display()method returning formatted string'(r1, r2)'. The existingsignature()method remains unchanged, returning[r1, r2]list for internal use byis_real_quadratic(),unit_rank(),cnf(), and other methods that depend on list indexing.number_field.py: Updated field page rendering (line 468) and search column formatting (line 853) to use
signature_display().test_numberfield.py: Added
test_signature_display()to verify parentheses format on field detail pages.Example
Note: Search URLs continue using
[r1,r2]format for parser compatibility. Data downloads use list format for machine readability.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.