ECQ: implement change points according to curve model displayed#6855
Merged
AndrewVSutherland merged 2 commits intoLMFDB:mainfrom Feb 6, 2026
Merged
ECQ: implement change points according to curve model displayed#6855AndrewVSutherland merged 2 commits intoLMFDB:mainfrom
AndrewVSutherland merged 2 commits intoLMFDB:mainfrom
Conversation
Member
|
I tried a bunch of random curves of varying positive rank and torsion, looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #5326 . When you switch between the three available curve models (minimal, homogeneous, "simplified" = short Weierstrass) any points on the page (generators, torsion generators, integral points) change appropriately.
Clicking on the eye-con (top right) reveals raw text for the equation and integral points, but not yet for the generators, since I could not get that to work for entries in a table.
Implementation details: I enhanced the existing code which computes the simplified model to also return a function taking an affine point (x,y) on the original model to a point (x',y') on the simplified model. (This is the identity if a1=a3=0.) When points are retrived from the database (generators, torsion gens and integral points) they are mapped to projective points and affine points on the simplified model, so there are three versions of all the point lists.
I checked several examples but checking more would be useful. My test cases included 14a2 (a1 nonzero, rank 1), 20a4 (a1=a3=0, 5 integral points, rank 0), 916c1 (a1=a3=0, 22 integral points, rank 2). You need examples will positive rank and nontrivial torsion and some integral points, with both a1=a3=0 (so simplified already) and not.