Skip to content

Added support for BIDS structure#32

Merged
acsenrafilho merged 4 commits intoLOAMRI:mainfrom
BDadmehr0:BIDS
Jun 29, 2025
Merged

Added support for BIDS structure#32
acsenrafilho merged 4 commits intoLOAMRI:mainfrom
BDadmehr0:BIDS

Conversation

@BDadmehr0
Copy link
Contributor

#19

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
asltk/utils.py 7.14% 13 Missing ⚠️

❌ Your patch status has failed because the patch coverage (7.14%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
asltk/utils.py 80.23% <7.14%> (-18.23%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acsenrafilho acsenrafilho self-requested a review June 26, 2025 21:22
@acsenrafilho
Copy link
Member

Hi @BDadmehr0 ! Thank you for the support in the asltk project!

I will revise the PR and assist you with further steps.
Could you please revise the unit tests for the improvements that you are placing in this PR?

Glad to have your help!

@BDadmehr0
Copy link
Contributor Author

BDadmehr0 commented Jun 26, 2025

Fix test_load_image_from_bids_structure_returns_valid_array by updating suffix to match existing ASL file 6c021e2

> pytest tests/test_utils.py -k "test_load_image_from_bids_structure_returns_valid_array" -v                                                                                                   ~/Github/asltk(BIDS2)@archlinux

===================================================================================================== test session starts =====================================================================================================
platform linux -- Python 3.13.3, pytest-8.3.5, pluggy-1.5.0 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /home/dadmehr/Github/asltk
configfile: pyproject.toml
plugins: Faker-37.1.0, mock-3.14.0, cov-6.0.0, anyio-4.8.0
collected 51 items / 50 deselected / 1 selected                                                                                                                                                                               

tests/test_utils.py::test_load_image_from_bids_structure_returns_valid_array PASSED                                                                                                                                     [100%]

====================================================================================================== warnings summary =======================================================================================================
<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyPacked has no __module__ attribute

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyObject has no __module__ attribute

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type swigvarlink has no __module__ attribute

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================================================================== 1 passed, 50 deselected, 3 warnings in 1.42s =========================================================================================

@acsenrafilho

@acsenrafilho acsenrafilho merged commit 6fdc2a5 into LOAMRI:main Jun 29, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants