Add default options to cbf, te_asl and dw_asl scripts#40
Merged
acsenrafilho merged 2 commits intodevelopfrom Jul 3, 2025
Merged
Add default options to cbf, te_asl and dw_asl scripts#40acsenrafilho merged 2 commits intodevelopfrom
acsenrafilho merged 2 commits intodevelopfrom
Conversation
Co-authored-by: acsenrafilho <9722993+acsenrafilho@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [Improvement] Add default options in the scripts (cfb, te_asl and dw_asl)
Add default options to cbf, te_asl and dw_asl scripts
Jul 3, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds default parameter values to the
cbf,te_asl, anddw_aslscripts, making them consistent with the existinggenerate_subtracted_asl_imagescript.Changes Made
The following parameters are now optional with sensible defaults:
[170.0, 270.0, 370.0, 520.0, 670.0, 1070.0, 1870.0][100.0, 100.0, 150.0, 150.0, 400.0, 800.0, 1800.0][13.56, 67.82, 122.08, 176.33, 230.59, 284.84, 339.1, 393.36](te_asl only)[0, 50, 100, 250](dw_asl only)Before
# These commands would fail with "required arguments" errors python -m asltk.scripts.cbf pcasl.nii m0.nii output/ python -m asltk.scripts.te_asl pcasl.nii m0.nii output/ python -m asltk.scripts.dw_asl pcasl.nii m0.nii output/After
Benefits
Testing
Fixes #22.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.