[REFACTOR] Standardize function interfaces in executor and reduce double pointers#340
Open
[REFACTOR] Standardize function interfaces in executor and reduce double pointers#340
Conversation
"Binding" file descriptors is commonly used with sockets, not with files.
This makes the interface the same as `handle_external_cmd()`.
- Change interface of `is_control_op_cmd_table()` to align with its name. - Reduce unnecessary intermediary variables.
It's a function that is not necessary and is only called once. The code is even shorter without the function call.
…om_list()` - Reducing the double pointers makes it more clear when list pointers are not getting moved forward. - The `get_token_from_list()` is not called anywhere anymore and is unnecessary.
The function is useful to check if the cmd_table_node is NULL. This partially reverts commit 7aa7040.
Owner
|
I'm ok to change this, but I don't feel any different. Do we really need to do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_builtin()to make the interface the same ashandle_external_cmd().get_cmd_table_type_from_list()more often.is_control_op_cmd_table()to align with its name.get_cmd_table_from_list()andget_token_from_list()bc they are unnecessary and the code is even shorter without these function calls.