Only save feature properties when actually needed#77
Only save feature properties when actually needed#77perliedman wants to merge 1 commit intomasterfrom
Conversation
|
Note that other than through Maybe the condition |
|
Adding some unit tests for this project might be worthwhile, and I'd be willing to write one for my assertion above, but I'm afraid setting up the framework from scratch is too daunting to me… |
|
You're right, should check |
|
In my case, clicking a feature triggers an update in a separate window without the need for any feedback in the map itself. I can work out which feature was clicked from its |
We store feature properties in our layers for use when a layer is interactive and/or can change feature styles after they're loaded. However, when this feature isn't enabled, storing the properties is unnecessary and can take up a lot of memory.
This PR makes sure properties are only saved when we actually need them.