Fix LocalHistoryService::list_targets to take the latest timestamp of each target#163
Merged
spb merged 2 commits intoLibera-Chat:masterfrom Jun 21, 2025
Merged
Fix LocalHistoryService::list_targets to take the latest timestamp of each target#163spb merged 2 commits intoLibera-Chat:masterfrom
spb merged 2 commits intoLibera-Chat:masterfrom
Conversation
…amp of each target ebc5a36 meant to sort by ascending timestamp before limiting, but by doing so it also changed the behavior to consider the earliest timestamp of each target instead of the latest. This fixes this behavior, at the cost of adding an explicit sorting step.
progval
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#159 meant to sort by ascending timestamp before limiting, but by doing so it also changed the behavior to consider the earliest timestamp of each target instead of the latest.
This fixes this behavior, at the cost of adding an explicit sorting step.
Fixes #162