Skip to content

docs(logging): correct LB_LOGGING_* names#991

Merged
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/logging_docs
Feb 10, 2026
Merged

docs(logging): correct LB_LOGGING_* names#991
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/logging_docs

Conversation

@JohnVillalovos
Copy link
Collaborator

Was LB_LOG_* but should be LB_LOGGING_*

Was `LB_LOG_*` but should be `LB_LOGGING_*`
Copilot AI review requested due to automatic review settings February 10, 2026 16:29
@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) February 10, 2026 16:30
@JohnVillalovos JohnVillalovos merged commit 88551cf into develop Feb 10, 2026
16 checks passed
@JohnVillalovos JohnVillalovos deleted the jlvillal/logging_docs branch February 10, 2026 16:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Docker environment variable documentation for logging settings to use the correct LB_LOGGING_* names (instead of LB_LOG_*) across the docs.

Changes:

  • Renamed documented logging env vars to LB_LOGGING_FOLDER, LB_LOGGING_LEVEL, and LB_LOGGING_SQL in installation docs.
  • Renamed documented logging env vars to LB_LOGGING_FOLDER, LB_LOGGING_LEVEL, and LB_LOGGING_SQL in basic configuration docs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/source/INSTALLATION.rst Corrects documented logging env var names for Docker configuration.
docs/source/BASIC-CONFIGURATION.rst Corrects documented logging env var names for Docker configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


``LB_LOG_FOLDER``
``LB_LOGGING_FOLDER``
Log directory (default: ``/var/log/librebooking``)
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documented default log directory here (/var/log/librebooking) doesn’t match the actual default used by the app and the provided .env.example (/var/log/librebooking/log). Updating this default in the docs would prevent misconfiguration/confusion for Docker users.

Suggested change
Log directory (default: ``/var/log/librebooking``)
Log directory (default: ``/var/log/librebooking/log``)

Copilot uses AI. Check for mistakes.

``LB_LOG_FOLDER``
``LB_LOGGING_FOLDER``
Log directory (default: ``/var/log/librebooking``)
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documented default log directory here (/var/log/librebooking) doesn’t match the actual default used by the app and the provided .env.example (/var/log/librebooking/log). Updating this default in the docs would prevent misconfiguration/confusion for Docker users.

Suggested change
Log directory (default: ``/var/log/librebooking``)
Log directory (default: ``/var/log/librebooking/log``)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant