tests: Fix variable reference in mul_to_multimul_checker#2709
Open
aobolensk wants to merge 7 commits intoLightning-AI:mainfrom
Open
tests: Fix variable reference in mul_to_multimul_checker#2709aobolensk wants to merge 7 commits intoLightning-AI:mainfrom
aobolensk wants to merge 7 commits intoLightning-AI:mainfrom
Conversation
aobolensk
requested review from
KaelanDt,
lantiga,
mruberry and
t-vi
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
IvanYashchuk
approved these changes
Nov 20, 2025
Collaborator
|
@KaelanDt, could you please take a look and help merge? |
riccardofelluga
approved these changes
Nov 20, 2025
Collaborator
riccardofelluga
left a comment
riccardofelluga
left a comment
There was a problem hiding this comment.
Nice catch! Thanks for your contribution! :D
Do you think it would be useful to add an assert to check that multimul is indeed not used when one or more tensors are not on CPU?
Contributor
Author
That's possible, but isn't that a purpose of this specific checker ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect value is mistakenly being checked in
mul_to_multimul_checkerspecifically for CPU case