🐛 Updated GlAlerts to use latest Glances Alerts API#1954
Open
sypticus wants to merge 2 commits intoLissy93:masterfrom
Open
🐛 Updated GlAlerts to use latest Glances Alerts API#1954sypticus wants to merge 2 commits intoLissy93:masterfrom
sypticus wants to merge 2 commits intoLissy93:masterfrom
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
Bugfix
Overview
The Glances alerts API has changed, and instead of returning a list of lists, it is now returning a list of objects
GlAlerts.vue is still trying to get values by index. This PR updates the Alerts widget to use this object.
Issue Number
1953
Code Quality Checklist (Please complete)