Open
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: Update dependency
Overview
Update
simple-iconsbecause I would like to use the HedgeDoc icon (introduced in v15 but I thought one might as well use the most recent version).Code Quality Checklist (Please complete)
I am not familiar with Javascript; I merely edited
package.json, built the container, and checked thatsi-hedgedocwas working. If there is anything else I should do, please let me know, though, I would prefer if you could take over this branch. 🙂simple-iconsremove some icons, which will affect some users of dashy(If a new config option is added) Attribute is outlined in the schema and documented(If a new dependency is added) Package is essential, and has been checked out for security or performance(If significant change) Bumps version in package.json