Draft
Conversation
Contributor
|
Just a drive-by, haven't considered your other questions! This is where you update the Reslang version: https://github.com/LiveRamp/reslang/blob/master/src/main.ts#L21 |
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
Since this introduces a breaking change, it might be best not to merge this until we can get more fixes into the current major version. This puts us in a really tough spot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #126
Use
/instead of.to separate the namespace from the rest of the topic name.Open questions:
/count as a valid topic name in terraform?EDIT:
terraform plandoesn't complain about the DOT (.) separators either.Maybe the above line does not guarantee that SLASH (
/) is valid.name/spaceintoname-spacein the previous code?kebabCase/snakeCasefunction worked.