Fix fetching position dataframe in SortedSpikesDecodingV1.get_ahead_behind_distance()#1540
Open
calderast wants to merge 2 commits intoLorenFrankLab:masterfrom
Open
Fix fetching position dataframe in SortedSpikesDecodingV1.get_ahead_behind_distance()#1540calderast wants to merge 2 commits intoLorenFrankLab:masterfrom
SortedSpikesDecodingV1.get_ahead_behind_distance()#1540calderast wants to merge 2 commits intoLorenFrankLab:masterfrom
Conversation
SortedSpikesDecodingV1.get_ahead_behind_distance()
Member
|
The failing tests might be addressed by merging #1534 and fetching upstream |
Contributor
Author
Yeah, the test failures for this PR are unrelated to this change, so waiting on that to merge (but would be great if this could happen soon or this could be merged first as we're trying to use this function) Also, should I add a test for this? It seems this entire case (where track_graph is None so get_ahead_behind_distance uses get_ahead_behind_distance2D) has never been run or tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fetch_position_inforeturns a tuple of(position_info, position_variable_names), but the.lochere is supposed to operate on just the dataframe. Fix it to grab theposition_infodataframe onlyspyglass/src/spyglass/decoding/v1/sorted_spikes.py
Lines 639 to 641 in 2d7bc52
Checklist:
CITATION.cffaltersnippet for release notes.CHANGELOG.mdwith PR number and description.