Benchmark parameters fixes#17
Open
siddhesh wants to merge 7 commits intoLuaJIT:masterfrom
siddhesh:arm64-params
Open
Benchmark parameters fixes#17siddhesh wants to merge 7 commits intoLuaJIT:masterfrom siddhesh:arm64-params
siddhesh wants to merge 7 commits intoLuaJIT:masterfrom
siddhesh:arm64-params
Conversation
… math.mod are renamed in lua5.1, hence, need to check the version pre-5.1. math.log10 is made obsolete in lua5.2, hence, 5.2 onwards, math.log10 should not be available.
This change scales the parameters so that most of the benchmarks run for a minimum of 5 seconds. Some benchmarks (such as sum-file and k-nucleotide) don't read the scaling parameter yet so they need to be changed.
Add loop to run the search multiple times.
Add support to compute sum multiple times in the benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches in this branch include patches in PR #16 and add on top of it. I could not find a way to add these patches to that PR.
The additional patches scale the arm64 parameters to have most benchmarks run for a minimum of 5 seconds to improve stability of the numbers. The patches additionally add scaling support to the k-nucleotide and sum-file benchmarks so that they can be configured to run long enough to give some more meaningful numbers.