feature: Add a replace parameter for single node additions#12
Open
kezz wants to merge 1 commit intoLuckPerms:mainfrom
Open
feature: Add a replace parameter for single node additions#12kezz wants to merge 1 commit intoLuckPerms:mainfrom
replace parameter for single node additions#12kezz wants to merge 1 commit intoLuckPerms:mainfrom
Conversation
This provides an "atomic" way of performing a replacement on a node without having to make two separate rest calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides an "atomic" way of performing a replacement on a node without having to make two separate rest calls.
Unsure if there is potentially a better solution, or more value in having a
/replaceendpoint with a parameter to pick the equality predicate. However, I think this is good as a nice addition for atomic remove/add for most use cases now.