Skip to content

Fix HitObjectLine not connecting when they should #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LumpBloom7 merged 1 commit into from
Feb 7, 2026
Merged

Fix HitObjectLine not connecting when they should #768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions osu.Game.Rulesets.Sentakki/UI/Components/HitObjectLine/LineLifetimeEntry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,11 @@

Colour = Color4.Gold;

int angleRange = delta == 4 ? 360 : 90 + 45 * delta;
int angleRange = delta >= 4 ? 360 : 90 + 45 * delta;

Check notice on line 78 in osu.Game.Rulesets.Sentakki/UI/Components/HitObjectLine/LineLifetimeEntry.cs

View check run for this annotation

codefactor.io / CodeFactor

osu.Game.Rulesets.Sentakki/UI/Components/HitObjectLine/LineLifetimeEntry.cs#L78 

Arithmetic expressions should declare precedence. (SA1407)

AngleRange = angleRange / 360f;

if (delta == 4)
if (delta >= 4)
{
Rotation = HitObjects.First().Lane.GetRotationForLane() - 180;
}
Expand Down