Skip to content

queue: WIP option to wait idle between internal submits #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jeremyg-lunarg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

queue: WIP option to wait idle between internal submits #233

jeremyg-lunarg wants to merge 1 commit into from

Conversation

@jeremyg-lunarg
Copy link
Collaborator

@jeremyg-lunarg jeremyg-lunarg commented Jan 2, 2026

This is the start of a fix for #232

@ci-tester-lunarg
Copy link
Collaborator

ci-tester-lunarg commented Jan 2, 2026

CI CrashDiagnosticLayer build # 550 running.

@ci-tester-lunarg
Copy link
Collaborator

ci-tester-lunarg commented Jan 2, 2026

CI CrashDiagnosticLayer build # 550 failed.

@jeremyg-lunarg
Copy link
Collaborator Author

jeremyg-lunarg commented Jan 2, 2026

@christophe-lunarg if you decide to persue this, you to add a setting and support Submit2 and BindSparse. Also there's a problem with the state updates. The command buffers after 14962 should all be NOT_STARTED. Also they should either not have sequence numbers yet or they should be assigned to make sense (14963 instead of 14774 and so on)

  IncompleteSubmits:
    - type: vkQueueSubmit
      startSeq: 14956
      endSeq: 14962
      SubmitInfos:
        - startSeq: 14956
          endSeq: 18446744073709551615
          state: INCOMPLETE
          CommandBuffers:
            - 0x0000000103F56A30[] COMPLETED 14958
            - 0x00000000E367F680[] COMPLETED 14959
            - 0x0000000096B06430[] COMPLETED 14960
            - 0x00000000FEE45EC0[] MAYBE_COMPLETE 14961
            - 0x0000000096B23DA0[] NOT_STARTED 14962
            - 0x00000001041F26F0[] COMPLETED 14774
            - 0x00000000F775D190[] COMPLETED 14858
            - 0x0000000096B68C90[] COMPLETED 14309
            - 0x00000000E36225B0[] COMPLETED 13787

@christophe-lunarg christophe-lunarg self-requested a review January 6, 2026 13:00
@christophe-lunarg christophe-lunarg self-assigned this Jan 6, 2026
@christophe-lunarg christophe-lunarg added the enhancement New feature or request label Jan 6, 2026
@ci-tester-lunarg
Copy link
Collaborator

ci-tester-lunarg commented Jan 13, 2026

CI CrashDiagnosticLayer build queued with queue ID 621647.

@ci-tester-lunarg
Copy link
Collaborator

ci-tester-lunarg commented Jan 13, 2026

CI CrashDiagnosticLayer build # 559 running.

@ci-tester-lunarg
Copy link
Collaborator

ci-tester-lunarg commented Jan 13, 2026

CI CrashDiagnosticLayer build queued with queue ID 621657.

@ci-tester-lunarg
Copy link
Collaborator

ci-tester-lunarg commented Jan 13, 2026

CI CrashDiagnosticLayer build # 560 running.

@ci-tester-lunarg
Copy link
Collaborator

ci-tester-lunarg commented Jan 13, 2026

CI CrashDiagnosticLayer build queued with queue ID 621666.

@ci-tester-lunarg
Copy link
Collaborator

ci-tester-lunarg commented Jan 13, 2026

CI CrashDiagnosticLayer build # 561 running.

@ci-tester-lunarg
Copy link
Collaborator

ci-tester-lunarg commented Jan 13, 2026

CI CrashDiagnosticLayer build # 561 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophe-lunarg christophe-lunarg Awaiting requested review from christophe-lunarg

At least 1 approving review is required to merge this pull request.

Assignees

@christophe-lunarg christophe-lunarg

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremyg-lunarg @ci-tester-lunarg @christophe-lunarg