URL decoding of parameters must be done after the parsing#601
Open
LeSuisse wants to merge 1 commit intoLuracast:v3from
Open
URL decoding of parameters must be done after the parsing#601LeSuisse wants to merge 1 commit intoLuracast:v3from
LeSuisse wants to merge 1 commit intoLuracast:v3from
Conversation
Otherwise percent-encoded / are recognized as an URL separator which does not respect the section 2.4 of the RFC3986 [0]. This is an issue if you have an string URL parameter with a / character since the URL is decoded before the finding the route corresponding the request you will either not find the route or find a route that does not match with the request. The URL must be decoded only when setting the parameters. [0] https://tools.ietf.org/html/rfc3986#section-2.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise percent-encoded / are recognized as an URL separator
which does not respect the section 2.4 of the RFC3986 [0].
This is an issue if you have an string URL parameter with a /
character since the URL is decoded before the finding the route
corresponding the request you will either not find the route
or find a route that does not match with the request. The URL
must be decoded only when setting the parameters.
[0] https://tools.ietf.org/html/rfc3986#section-2.4