new: [Bookmarks] allow site admins to create global bookmarks#10377
Open
goodlandsecurity wants to merge 1 commit intoMISP:developfrom
Open
new: [Bookmarks] allow site admins to create global bookmarks#10377goodlandsecurity wants to merge 1 commit intoMISP:developfrom
goodlandsecurity wants to merge 1 commit intoMISP:developfrom
Conversation
Member
|
That would indeed be handy, but it is a bit dangerous as it is - could you modify it so that only site admins can add global bookmarks? Also, could you add a new db upgrade script to accomodate for the new field? Have a look at for example update 138, just search AppModel.php for 138 to see what was added to make it work. Thanks for the PR and sorry that it took this long to respond. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR allows site admins to create global bookmarks (exposed to all users on an instance). This feature will be especially beneficial in community instances, allowing site admins to share bookmarks for search queries to view intel specific to an industry, threat actor, threat type, etc. while not requiring the end user to need to create their own.
Questions