Skip to content

Nptyping shapefix #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fatmaf wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Nptyping shapefix #18

fatmaf wants to merge 3 commits into from

Conversation

@fatmaf
Copy link

@fatmaf fatmaf commented Jul 16, 2022

Refactored/updated nptyping annotations to include shape.

Untri8ium
Untri8ium approved these changes Jan 7, 2025
View reviewed changes
Copy link

@Untri8ium Untri8ium left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
The codes don’t work anymore without this fix.
This is my first time contributing to this repo, but is this still open for updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Untri8ium Untri8ium Untri8ium approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fatmaf @Untri8ium