Compression: automatically propagate constants and remove unused nodes#8
Merged
Compression: automatically propagate constants and remove unused nodes#8
Conversation
Member
|
lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables the propagation of constants (true or false), and the removal of unused nodes (those not connected to a root node).
circuit.tensorize(), or when manually callingcircuit.remove_unused_nodes().Users should be aware that Python references to unused nodes become invalid after calling
.tensorize().This PR adds additional tests for the propagation and elimination. I confirm all tests pass, also those in DeepLog.
This PR additionally exposes through the Python interface:
.nb_root_nodes(),.remove_unused_nodes(), andklay.utils.circuit_to_dot(circuit, dot_filepath). The latter is more for debugging purposes.Worst case in the future, we can again quickly disable this like before