Skip to content

[DOP-22129] Allow using etl-entities 2.5.0#40

Merged
dolfinus merged 1 commit intodevelopfrom
feature/DOP-22129
Jan 28, 2025
Merged

[DOP-22129] Allow using etl-entities 2.5.0#40
dolfinus merged 1 commit intodevelopfrom
feature/DOP-22129

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Jan 27, 2025

Change Summary

Add test cases for etl-entities==2.5.0.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Jan 27, 2025
@dolfinus dolfinus marked this pull request as draft January 27, 2025 13:05
@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (6143423) to head (e05a326).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
conftest.py 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #40      +/-   ##
===========================================
+ Coverage    91.66%   91.93%   +0.26%     
===========================================
  Files            3        3              
  Lines          108      124      +16     
  Branches         8        9       +1     
===========================================
+ Hits            99      114      +15     
  Misses           7        7              
- Partials         2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus marked this pull request as ready for review January 27, 2025 15:22
@dolfinus dolfinus merged commit 53f42a5 into develop Jan 28, 2025
14 checks passed
@dolfinus dolfinus deleted the feature/DOP-22129 branch January 28, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants