Support generating representative docs when using online modelling#1618
Open
27pchrisl wants to merge 1 commit intoMaartenGr:masterfrom
Open
Support generating representative docs when using online modelling#161827pchrisl wants to merge 1 commit intoMaartenGr:masterfrom
27pchrisl wants to merge 1 commit intoMaartenGr:masterfrom
Conversation
Owner
|
Thank you for the PR! You might have missed the CONTRIBUTING.md file where you can an overview of the steps we generally take when opening up a new PR. The reason why I link that file is that it is not clear to me what the exact issue is that you are fixing. Could you first create a reproducible example such that I can also see what the exact error/issue is? That way, it is easier to for me what the problem is and what could be potential ways to fix it. |
Author
|
Hi @MaartenGr, I wrote this up in an issue. Fixes #1620 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first time you fit an online model and request representative docs this works fine as every doc you fitted with will be in a cluster somewhere.
The second time you fit with a second set of docs, causing new clusters to be created, it's possible that none of the docs you passed fit into any of the existing clusters. This causes the
_extract_representative_docsmethod to fail. Which results in you not being able to obtain representative docs for your new clusters.This PR resolves this, so that
_extract_representative_docswill return entries for all the topics, but some may be empty, based on the set of docs you provided.