transform method handle a single document with provided embedidngs#2043
Open
1jamesthompson1 wants to merge 1 commit intoMaartenGr:masterfrom
Open
transform method handle a single document with provided embedidngs#20431jamesthompson1 wants to merge 1 commit intoMaartenGr:masterfrom
transform method handle a single document with provided embedidngs#20431jamesthompson1 wants to merge 1 commit intoMaartenGr:masterfrom
Conversation
… transform function.
MaartenGr
reviewed
Jun 13, 2024
Comment on lines
+504
to
+505
| if len(documents) == 1 and isinstance(embeddings, np.ndarray) and embeddings.ndim == 1: | ||
| embeddings = embeddings.reshape(1,-1) |
Owner
There was a problem hiding this comment.
The embeddings that you can pass to .transform is typed as np.ndarray which is actually quite misleading (sorry!) as it can technically take the form of any iterable (but mostly just np.ndarray-like structures, such as a scipy sparse matrix). As such, doing something like embeddings.ndim == 1 might break here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is as discussed here: #2018
I added some tests just for some sanity checks. Looking at what tests you have it seems you would'nt want them moving forward?