Open
Conversation
Proposed solution to not having enough topics and the call visualize_topics() resulting in an Error.
MaartenGr
reviewed
Dec 27, 2024
Owner
MaartenGr
left a comment
There was a problem hiding this comment.
Thank you for the PR! I left a couple of small questions/comments.
Comment on lines
+60
to
+62
| elif len(topics) < 5: | ||
| warnings.warn("Too few topics to display.") | ||
| return |
Owner
There was a problem hiding this comment.
Couple of questions:
- What makes you choose the value of < 5 here? Is it working for 4 topics but it is for 5?
- Should we raise an error rather than return nothing after a warning? By returning None, we might also have to change the typing.
- Could you extend the description a bit more? Perhaps explain that we need more topics in order to properly visualize them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed solution to not having enough topics and the call visualize_topics() resulting in an Error.
What does this PR do?
Fixes #2247.
Not sure whether this requires updating documentation or a test. If yes, happy to write it.
Before submitting