Feat: add conditional ORM context connection based on configuration#41
Merged
Feat: add conditional ORM context connection based on configuration#41
Conversation
Update composer.json
update ci process
Release add PUT
Release 1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #41 +/- ##
=============================================
+ Coverage 84.94% 85.66% +0.71%
- Complexity 82 85 +3
=============================================
Files 6 6
Lines 279 286 +7
=============================================
+ Hits 237 245 +8
+ Misses 42 41 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
serhiidonii
approved these changes
May 4, 2025
Yozhef
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update bundle configuration: Introduced the use_orm_context flag to manage whether the ORM context should be connected or not.
Ensure DoctrineResetManager is only connected when ORM context is enabled, making the system more flexible based on the configuration.
Modify tests: Adjusted tests to verify the correct behavior when the ORM context is enabled and when it's disabled, ensuring that the ORMContext and DoctrineResetManager are only registered in the container when required.
Improve container initialization: Now, the ORM context configuration (orm_context.xml) is loaded conditionally based on the use_orm_context value. This prevents unnecessary loading of services when ORM context is not needed.
This change makes the bundle more adaptable and avoids unnecessary service registrations when ORM context is disabled.