Skip to content

Feat: add conditional ORM context connection based on configuration#41

Merged
Yozhef merged 21 commits intodevelopfrom
feat/orc-111-update-configuration
May 6, 2025
Merged

Feat: add conditional ORM context connection based on configuration#41
Yozhef merged 21 commits intodevelopfrom
feat/orc-111-update-configuration

Conversation

@ganzyukv
Copy link
Contributor

Update bundle configuration: Introduced the use_orm_context flag to manage whether the ORM context should be connected or not.

  • Ensure DoctrineResetManager is only connected when ORM context is enabled, making the system more flexible based on the configuration.

  • Modify tests: Adjusted tests to verify the correct behavior when the ORM context is enabled and when it's disabled, ensuring that the ORMContext and DoctrineResetManager are only registered in the container when required.

  • Improve container initialization: Now, the ORM context configuration (orm_context.xml) is loaded conditionally based on the use_orm_context value. This prevents unnecessary loading of services when ORM context is not needed.

This change makes the bundle more adaptable and avoids unnecessary service registrations when ORM context is disabled.

@ganzyukv ganzyukv requested a review from serhiidonii April 30, 2025 14:58
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.66%. Comparing base (8013b68) to head (23ac198).
Report is 22 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #41      +/-   ##
=============================================
+ Coverage      84.94%   85.66%   +0.71%     
- Complexity        82       85       +3     
=============================================
  Files              6        6              
  Lines            279      286       +7     
=============================================
+ Hits             237      245       +8     
+ Misses            42       41       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ganzyukv ganzyukv requested a review from Yozhef April 30, 2025 15:28
@Yozhef Yozhef merged commit ca03ba8 into develop May 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants