calendar: clarify pastDaysCount and broadcastPastEvents#357
Merged
khassel merged 1 commit intoMagicMirrorOrg:masterfrom Feb 6, 2026
Merged
calendar: clarify pastDaysCount and broadcastPastEvents#357khassel merged 1 commit intoMagicMirrorOrg:masterfrom
khassel merged 1 commit intoMagicMirrorOrg:masterfrom
Conversation
khassel
reviewed
Feb 6, 2026
Collaborator
khassel
left a comment
khassel
left a comment
There was a problem hiding this comment.
I'm fine with this but would merge it against master, otherwise the change is released in April ...
Resolves MagicMirrorOrg#290 - Clarify that pastDaysCount only affects broadcasts, not display - Explain that broadcastPastEvents requires pastDaysCount to be set - Fix incorrect reference to maximumNumberOfDays (should be pastDaysCount) - Emphasize that calendar module never displays past events The previous documentation caused confusion as users expected pastDaysCount to show past events in the calendar display, when it only affects the CALENDAR_EVENTS broadcast to other modules.
KristjanESPERANTO
force-pushed
the
fix/290
branch
from
c69311e to
c692c8d
Compare
Contributor
Author
|
Okay, done :-) |
khassel
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #290
The previous documentation caused confusion as users expected pastDaysCount to show past events in the calendar display, when it only affects the CALENDAR_EVENTS broadcast to other modules.