Merged
Conversation
- Add Node.js version matrix alongside Python versions - Integrate JavaScript dependency installation step - Add installation verification using custom function - Implement test coverage reporting with Codecov - Update workflow to run on main and develop branches - Improve caching for both Python and Node.js dependencies - Add more detailed emoji-based step descriptions - Configure conditional coverage upload for specific matrix combination Improves CI/CD robustness and provides more comprehensive testing across different runtime environments.
- Improve code formatting and readability - Add more detailed error handling and diagnostic information - Enhance logging and output for connection tests - Restructure test configurations for better flexibility - Add more comprehensive error messages and troubleshooting hints - Optimize connection testing logic with clearer separation of concerns Provides a more robust and informative diagnostic tool for S3 connection testing, with improved error reporting and user guidance.
- Replace default npm caching with explicit actions/cache@v4 - Configure cache key using runner OS, Node version, and package-lock.json hash - Add restore keys to improve cache hit rates - Remove redundant cache configuration from setup-node step - Enhance CI workflow dependency management performance Improves build efficiency and reduces unnecessary dependency downloads in CI pipeline
…endencies - Added package-lock.json for the S3 to Storacha JavaScript project - Locked dependency versions for @aws-sdk/client-s3 and @storacha/client - Ensures consistent dependency installation across development environments - Specifies Node.js engine requirement of >=18.0.0
…3 library - Add type ignore comments to resolve mypy type checking warnings - Update error handling in RetryHandler to support more robust error scenarios - Modify migrate script to display multiple errors instead of single error - Enhance S3 diagnostic script to safely handle empty access key - Improve subprocess error handling with more robust error code management - Ensure consistent error reporting across different library components
refactor(examples): Enhance S3 connection diagnostics script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors across CI/CD configuration, example scripts, and development dependencies. The main highlights are the addition of Node.js support and test coverage reporting in CI, modernization and cleanup of the S3 migration example, and enhanced development tooling for Python testing and coverage.
CI/CD Workflow Enhancements:
.github/workflows/ci.yml) [1] [2]Example Script Refactors:
examples/migrate.pyto use configuration from a JSON file, list S3 files before migration, and provide more detailed migration status and error reporting. The script now prompts for confirmation before migrating and handles dry-run mode more clearly. (examples/migrate.py)examples/diagnose_s3.pyby switching to double quotes, formatting, and clearer error handling and configuration setup. (examples/diagnose_s3.py) [1] [2] [3] [4] [5] [6]Development Tooling:
pyproject.toml, includingpytest-cov,pytest-asyncio,python-dotenv, andboto3for improved testing and environment management. (pyproject.toml)pytestandcoverageinpyproject.tomlto standardize test discovery, markers, and coverage reporting. (pyproject.toml)