Skip to content

Comments

feat: initial library setup#6

Merged
manny-uncharted merged 2 commits intomainfrom
feat/initial-setup
Jul 6, 2025
Merged

feat: initial library setup#6
manny-uncharted merged 2 commits intomainfrom
feat/initial-setup

Conversation

@0-th
Copy link
Collaborator

@0-th 0-th commented Jul 6, 2025

No description provided.

@0-th 0-th marked this pull request as ready for review July 6, 2025 19:05
@0-th
Copy link
Collaborator Author

0-th commented Jul 6, 2025

@manny-uncharted @Aldorax could you give it a look before I merge?

@Aldorax
Copy link
Contributor

Aldorax commented Jul 6, 2025

Will look into this and revert soon

@manny-uncharted @Aldorax could you give it a look before I merge?

@manny-uncharted manny-uncharted requested a review from Copilot July 6, 2025 22:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Initial setup for the py_s3_storacha library, including scaffolding, configuration, and CI.

  • Add placeholder test and basic package init
  • Configure build and project metadata in pyproject.toml
  • Provide Makefile targets and GitHub Actions CI pipeline

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_placeholder.py Add a trivial placeholder test
src/py_s3_storacha/init.py Initialize package with docstring and __version__
pyproject.toml Define project metadata, dependencies, and build settings
makefile Introduce common development commands (install, lint, test)
.github/workflows/ci.yml Set up CI for formatting, linting, type checking, and tests
Comments suppressed due to low confidence (2)

tests/test_placeholder.py:2

  • This placeholder test doesn’t cover any real functionality; consider replacing it with tests that exercise your library’s public API (e.g., importing the module, calling core functions).
    assert True

pyproject.toml:36

  • The repository URL appears to differ from the package name; ensure the "Homepage" and "Issues" URLs point to the correct py_s3_storacha repository.
Homepage = "https://github.com/Mahd-Mehn/MM-python-s3-storacha"

@manny-uncharted manny-uncharted merged commit 1592aa5 into main Jul 6, 2025
3 checks passed
@0-th 0-th deleted the feat/initial-setup branch July 7, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants