Conversation
Collaborator
Author
|
@manny-uncharted @Aldorax could you give it a look before I merge? |
Contributor
|
Will look into this and revert soon
|
There was a problem hiding this comment.
Pull Request Overview
Initial setup for the py_s3_storacha library, including scaffolding, configuration, and CI.
- Add placeholder test and basic package init
- Configure build and project metadata in
pyproject.toml - Provide Makefile targets and GitHub Actions CI pipeline
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_placeholder.py | Add a trivial placeholder test |
| src/py_s3_storacha/init.py | Initialize package with docstring and __version__ |
| pyproject.toml | Define project metadata, dependencies, and build settings |
| makefile | Introduce common development commands (install, lint, test) |
| .github/workflows/ci.yml | Set up CI for formatting, linting, type checking, and tests |
Comments suppressed due to low confidence (2)
tests/test_placeholder.py:2
- This placeholder test doesn’t cover any real functionality; consider replacing it with tests that exercise your library’s public API (e.g., importing the module, calling core functions).
assert True
pyproject.toml:36
- The repository URL appears to differ from the package name; ensure the "Homepage" and "Issues" URLs point to the correct
py_s3_storacharepository.
Homepage = "https://github.com/Mahd-Mehn/MM-python-s3-storacha"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.