Skip to content

fix: Use sum() instead of count() in HandCalculator.estimate_hand_value() #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Apricot-S wants to merge 1 commit into from
Closed

fix: Use sum() instead of count() in HandCalculator.estimate_hand_value() #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mahjong/hand_calculating/hand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from collections.abc import Collection

from mahjong.agari import Agari
from mahjong.constants import CHUN, FIVE_RED_MAN, FIVE_RED_PIN, FIVE_RED_SOU, HAKU, HATSU
from mahjong.constants import AKA_DORA_LIST, CHUN, HAKU, HATSU
from mahjong.hand_calculating.divider import HandDivider
from mahjong.hand_calculating.fu import FuCalculator
from mahjong.hand_calculating.hand_config import HandConfig
Expand Down Expand Up @@ -168,7 +168,7 @@ def estimate_hand_value(

precomputed_aka_dora = 0
if config.options.has_aka_dora:
precomputed_aka_dora = tiles.count(FIVE_RED_MAN) + tiles.count(FIVE_RED_PIN) + tiles.count(FIVE_RED_SOU)
precomputed_aka_dora = sum(t in AKA_DORA_LIST for t in tiles)

precomputed_ura_dora = 0
if config.is_riichi or config.is_daburu_riichi:
Expand Down