Change bitnami/valkey to bitnamilegacy/valkey #2042
Conversation
Due to Bitnami Valkey packages becoming hardened, only the :latest tag is available within the bitnami public catalogue. Without this change, the following error occurs: "Error response from daemon: failed to resolve reference "docker.io/bitnami/valkey:8.0": docker.io/bitnami/valkey:8.0: not found" Source: https://hub.docker.com/r/bitnami/valkey#%EF%B8%8F-important-notice-upcoming-changes-to-the-bitnami-catalog ------------------ Starting August 28th, over two weeks, all existing container images, including older or versioned tags (e.g., 2.50.0, 10.6), will be migrated from the public catalog (docker.io/bitnami) to the “Bitnami Legacy” repository (docker.io/bitnamilegacy), where they will no longer receive updates. -----------------
WalkthroughReplaced the Valkey container image reference in two docker-compose files and updated the mounted Valkey data volume path in both files. No runtime control flow or exported/public API declarations were modified. Changes
Sequence Diagram(s)(omitted — configuration-only changes; no control-flow modifications) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Updated docker-compose.prod.yaml to bitnamilegacy
|
Updated docker-compose.prod.yaml |
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| image: docker.io/bitnamilegacy/valkey:8.0 | ||
| environment: | ||
| - ALLOW_EMPTY_PASSWORD=yes | ||
| - VALKEY_DISABLE_COMMANDS=FLUSHDB,FLUSHALL | ||
| volumes: | ||
| - valkey-data:/bitnami/valkey/data | ||
| - valkey-data:/bitnamilegacy/valkey/data |
There was a problem hiding this comment.
🧩 Analysis chain
Verify volume path change doesn't cause data loss and that the image exists at the new registry.
The image reference and volume mount path have been updated to reflect Bitnami's migration to the legacy repository. However, the volume path change from /bitnami/valkey/data to /bitnamilegacy/valkey/data could affect data persistence if this is an existing deployment.
Additionally, confirm that the image tag :8.0 exists in the docker.io/bitnamilegacy registry, since this is a breaking change.
Run the following verification to check image availability and consistency across compose files:
🏁 Script executed:
#!/bin/bash
# Description: Verify the Valkey image exists at the new registry and check consistency with other compose files.
# Check if the new image reference exists in the registry
echo "Checking if docker.io/bitnamilegacy/valkey:8.0 is accessible..."
docker manifest inspect docker.io/bitnamilegacy/valkey:8.0 2>&1 | head -20
echo ""
echo "Searching for all Valkey references in docker-compose files..."
# Search for Valkey service definitions in all compose files
fd -e yaml -e yml . -x grep -l "valkey:" {} \;
echo ""
echo "Verifying consistency of Valkey image and volume paths across all compose files..."
# Find all lines with valkey image or volume references
rg -n "bitnamilegacy/valkey|valkey-data:" --type yamlLength of output: 680
Critical: Volume mount path inconsistency across compose files—data persistence at risk.
While the image update to docker.io/bitnamilegacy/valkey:8.0 is consistent across files, the volume mount paths have diverged:
docker-compose.prod.yamlline 76:valkey-data:/bitnamilegacy/valkey/datadocker-compose.db.yamlline 25:valkey-data:/bitnami/valkey/data
Both reference the same volume name (valkey-data) but mount to different paths inside their containers. This inconsistency must be resolved: either both should use /bitnamilegacy/valkey/data to match the image migration, or the migration in docker-compose.prod.yaml was incomplete and docker-compose.db.yaml also needs updating.
🤖 Prompt for AI Agents
In docker-compose.prod.yaml around lines 71-76 the volume mount uses
valkey-data:/bitnamilegacy/valkey/data which conflicts with
docker-compose.db.yaml (line 25) that mounts valkey-data:/bitnami/valkey/data;
pick the correct in-container path (prefer /bitnamilegacy/valkey/data to match
the updated image) and update the other compose file so both use the identical
mount path for valkey-data, then verify the volumes section references the same
volume name and redeploy/restart services to ensure persisted data lands in the
expected location.
Updated bitnami to bitnamilegacy
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docker-compose.db.yaml (1)
18-18: ✅ Image and volume mount updates correctly aligned with Bitnami migration.Both the image reference (
docker.io/bitnamilegacy/valkey:8.0) and volume mount path (/bitnamilegacy/valkey/data) are now consistent with the Bitnami repository migration and matchdocker-compose.prod.yaml. The past review's flag about inconsistency between compose files has been resolved.Optional: Provide migration guidance for existing deployments. If this compose file is used for local development and any developers have persisted Valkey data from prior deployments using the old image path (
/bitnami/valkey/data), consider documenting the volume path change or providing a migration step to avoid confusion when upgrading to this version.Also applies to: 25-25
docker-compose.prod.yaml (1)
71-71: ✅ Production image and volume updates aligned with staging environment.The image reference and volume mount path are now consistent with
docker-compose.db.yaml, resolving the earlier inconsistency flagged in past reviews. Thedocker.io/bitnamilegacy/valkey:8.0image is the correct target post-migration (Sept 29, 2025 deadline).Optional: Document data migration path for existing production deployments. If this is a production environment upgrade with existing persisted Valkey data, ensure deployment documentation clarifies how data in the old volume path will be handled, or provide backup/restore procedures to prevent data loss during the rollout.
Also applies to: 76-76
|
@coderabbitai run pre-merge checks |
✅ Actions performedRunning Pre-merge checks. Results will be posted in the summary comment once complete. |
1 participant
Description
Due to Bitnami changes in their repository, only the :latest tag is available within the bitnami public catalogue, with this project using on version tag 8.0.
Without this change, the following error occurs when running pnpm docker:db:up: "Error response from daemon: failed to resolve reference "docker.io/bitnami/valkey:8.0": docker.io/bitnami/valkey:8.0: not found"
Source: https://hub.docker.com/r/bitnami/valkey#%EF%B8%8F-important-notice-upcoming-changes-to-the-bitnami-catalog --"
Starting August 28th, over two weeks, all existing container images, including older or versioned tags (e.g., 2.50.0, 10.6), will be migrated from the public catalog (docker.io/bitnami) to the “Bitnami Legacy” repository (docker.io/bitnamilegacy), where they will no longer receive updates.
"
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
This was changed in my local system, and after running 'pnpm docker:db:up' the errors dissapeared. This is a simple fix where the repository previously referenced (bitnami) no longer contains tagged versions.
Checklist
Additional Notes
Add any other context about the pull request here.
Screenshots/Recordings
Add screenshots or recordings here if applicable.
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit