Skip to content

Changed Feature Name from native to management_console#22474

Open
DavidResende0 wants to merge 1 commit intoManageIQ:masterfrom
DavidResende0:management_console-fix
Open

Changed Feature Name from native to management_console#22474
DavidResende0 wants to merge 1 commit intoManageIQ:masterfrom
DavidResende0:management_console-fix

Conversation

@DavidResende0
Copy link
Member

@DavidResende0 DavidResende0 commented Apr 24, 2023 •
edited
Loading

Follow up to: ManageIQ/manageiq-ui-classic#8758

Changes the feature name for the IBM providers from native_console to management_console since native_console is already used by the RHV provider. Also fixes a bug in the ui that was being caused by this overlap of feature names.

Other PRs:
ui -> ManageIQ/manageiq-ui-classic#8762
Lenovo -> ManageIQ/manageiq-providers-lenovo#389
vmware -> ManageIQ/manageiq-providers-vmware#874
ibm_power_hmc -> ManageIQ/manageiq-providers-ibm_power_hmc#136
ibm_terraform -> ManageIQ/manageiq-providers-ibm_terraform#94
ibm_cloud -> ManageIQ/manageiq-providers-ibm_cloud#451
ibm_power_vc -> ManageIQ/manageiq-providers-ibm_power_vc#90

This was referenced Apr 24, 2023
Open
Open
Open
@DavidResende0
Copy link
Member Author

DavidResende0 commented Apr 24, 2023 •
edited
Loading

@agrare can you make sure I'm not missing anything or changed something that's not necessary to change.

@agrare agrare self-assigned this Apr 24, 2023
@DavidResende0 DavidResende0 force-pushed the management_console-fix branch from d70a3ed to e85caa1 Compare April 24, 2023 20:47
agrare
agrare requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@agrare agrare left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need supports_not :management_console in ExtManagementSystem
We also need to change the supports feature for the supports feature from :native_console to :management_console in the providers which implement console_url for ExtManagementSystems.

@agrare
Copy link
Member

agrare commented Jun 8, 2023

@DavidResende0 we still need to update the other providers which implement this at the EMS level per #22474 (review)

@DavidResende0
Copy link
Member Author

DavidResende0 commented Jun 8, 2023

@DavidResende0 we still need to update the other providers which implement this at the EMS level per #22474 (review)

Are there other providers besides ManageIQ/manageiq-providers-ibm_power_hmc#136 and ManageIQ/manageiq-providers-ibm_cloud#451 that I'm missing?

Also I'm I missing something in these prs?

@agrare
Copy link
Member

agrare commented Jun 8, 2023

Are there other providers besides ManageIQ/manageiq-providers-ibm_power_hmc#136 and ManageIQ/manageiq-providers-ibm_cloud#451 that I'm missing?

Yes, https://github.com/search?q=org%3AManageIQ+%22supports+%3Anative_console%22&type=code

@DavidResende0 DavidResende0 force-pushed the management_console-fix branch from 80ce8af to ca3126e Compare July 12, 2023 15:12
This was referenced Jul 12, 2023
Open
Open
Open
Open
agrare
agrare reviewed Jul 12, 2023
View reviewed changes
@DavidResende0 DavidResende0 force-pushed the management_console-fix branch from ca3126e to 56897fa Compare July 12, 2023 16:00
kbrock
kbrock reviewed Jul 12, 2023
View reviewed changes
db/fixtures/miq_user_roles.yml
- vm_html5_console
- vm_vmrc_console
- vm_management_console
- vm_native_console
Copy link
Member

@kbrock kbrock Jul 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still want the vm_native_console entries?

ugh. this probably requires a migration and everything.

^ ignore. this looks great

Copy link
Member

@agrare agrare Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes because vm_native_console is still a valid feature (ovirt/rhv vm console), it was being overloaded by something else (web browser details page)

@DavidResende0 DavidResende0 force-pushed the management_console-fix branch from 56897fa to 5c665f5 Compare July 26, 2023 16:22
@miq-bot
Copy link
Member

miq-bot commented Jul 26, 2023

Checked commit DavidResende0@5c665f5 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@agrare
Copy link
Member

agrare commented Oct 27, 2023

@DavidResende0 what is the status of this? Were we waiting on testing or other providers?

@DavidResende0
Copy link
Member Author

DavidResende0 commented Oct 27, 2023 •
edited
Loading

@DavidResende0 what is the status of this? Were we waiting on testing or other providers?

I think these changes cover all the needed providers and everything seems to work on the one's I've tested but I haven't been able to test every provider.

@miq-bot
Copy link
Member

miq-bot commented Nov 2, 2023

This pull request is not mergeable. Please rebase and repush.

@miq-bot miq-bot added the stale label Feb 5, 2024
@miq-bot
Copy link
Member

miq-bot commented Feb 5, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

6 similar comments
@miq-bot
Copy link
Member

miq-bot commented May 6, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Aug 12, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Nov 25, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Mar 3, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Jun 9, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Dec 26, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbrock kbrock kbrock left review comments

@agrare agrare agrare requested changes

@bdunne bdunne Awaiting requested review from bdunne bdunne is a code owner

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@agrare agrare

Labels

bug providers stale unmergeable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DavidResende0 @agrare @miq-bot @kbrock