lint_fragcomp #586
Merged
lint_fragcomp #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
commented
Jun 27, 2025
Comment on lines
+59
to
+60
| rt_tol_seconds: float, | ||
| mass_tol_ppm: float, |
Collaborator
Author
There was a problem hiding this comment.
removed double defaults
GeorgWa
approved these changes
Jun 30, 2025
| psm_df = fragment_competition(psm_df, frag_df, cycle) | ||
|
|
||
| assert len(psm_df) == 4 | ||
| pd.testing.assert_frame_equal( |
Collaborator
There was a problem hiding this comment.
Maybe a bit nicer than just checking for the length
Collaborator
Author
There was a problem hiding this comment.
"a bit nicer" in the sense "actually a test"? :-D
alphadia/fragcomp/fragcomp.py
Outdated
| thread_idx: int | ||
| The thread index. Each thread will handle one dia window. | ||
| The function will be wrapped in a pjit decorator and will be parallelized over this index. | ||
| The pjit decorator effectively changes the type of this argument to `np.ndarray` and threa-parallelizes |
Collaborator
There was a problem hiding this comment.
(nit) thread-parallelizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix strict linting issues for the fragcomp package.
related to MannLabs/alphatims#299