#149 Add Feature Padding for delimited records#302
Open
telljimmy wants to merge 2 commits intoMarcosMeli:masterfrom
Open
#149 Add Feature Padding for delimited records#302telljimmy wants to merge 2 commits intoMarcosMeli:masterfrom
telljimmy wants to merge 2 commits intoMarcosMeli:masterfrom
Conversation
added 2 commits
August 15, 2018 18:10
…mbiguous. Explicitly declared arguments instead of argument array MarcosMeli#149
Collaborator
|
Hi Jimmy Thank you for your code and your explanation. Thank you, Matthias |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for adding the feature against the issue
Support Padding via a Converted in the library #149
The only change done previous code is to move a chunk into a function. the long switch case for assigning converter is moved to GetConverter function so it can be used in 2 places.