Closed
Conversation
rockfordlhotka
requested changes
Dec 18, 2024
Member
rockfordlhotka
left a comment
rockfordlhotka
left a comment
There was a problem hiding this comment.
Because there are some breaking changes in this PR I'll make the version go to 7.1.0 instead of 7.0.7.
Can you please edit the /csla/releasenotes.md file and provide some guidance to a future dev as to what are the breaking changes and what they need to change in their AddCsla config to move from 7.0.6 to 7.1.0?
Otherwise I'm good with the changes in the PR - totally impressed by how much work you put in!
Member
|
Not needed as per discussion in Discord |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4315
Backported the context manager changes from 8 down to 7.