Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses event listener memory leaks by implementing proper cleanup strategies for event handlers. The changes prevent duplicate event listener registrations that would occur when the editor is reset multiple times.
Changes:
- Implemented cleanup logic for gutter hover effect event listeners to prevent duplicates when line numbers are toggled
- Moved window and viewport resize event listeners from
resetEditor()to module level to prevent duplicate registrations on editor resets
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CoreEditor/src/styling/config.ts | Added storage for event handlers and cleanup logic to remove old gutter listeners before attaching new ones |
| CoreEditor/src/core.ts | Relocated window resize and visualViewport listeners to module level, fixing memory leak from duplicate registrations in resetEditor() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.