Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the BlockWrapper functionality from the CoreEditor to fix a regression where Chinese text input in tables and code blocks would disappear or become garbled (issue #1226). The changes revert to the previous decoration-based approach that worked correctly in version 1.28.0.
Changes:
- Removed
BlockWrapperusage and associatedcreateBlockPluginhelper function - Removed wrapper div elements (
cm-md-tableWrapper,cm-md-codeBlockWrapper) that were wrapping tables and code blocks - Cleaned up imports across affected files to remove unused functions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CoreEditor/src/styling/nodes/table.ts | Removed BlockWrapper plugin for table styling, keeping only line decoration |
| CoreEditor/src/styling/nodes/code.ts | Removed BlockWrapper plugin for code blocks, including HTML attributes (spellcheck, autocorrect, etc.) |
| CoreEditor/src/styling/matchers/lezer.ts | Deleted createBlockWrappers function that was no longer needed |
| CoreEditor/src/styling/helper.ts | Deleted createBlockPlugin helper function and removed BlockWrapper import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a regression as mentioned in #1226.