Skip to content

Replace straight quotes with curly quotes in user-facing strings#1232

Merged
cyanzhong merged 4 commits intomainfrom
copilot/use-curly-quotes
Feb 6, 2026
Merged

Replace straight quotes with curly quotes in user-facing strings#1232
cyanzhong merged 4 commits intomainfrom
copilot/use-curly-quotes

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

Plan: Use Curly Quotes in User-Facing Strings ✅

  • Understand the current state of quotes in the codebase
  • Replace straight quotes with curly quotes in AppResources.swift
    • Replace single quotes (') with curly quotes (')
    • Replace double quotes (") with curly quotes (" and ")
  • Update corresponding xcstrings files with matching curly quotes
    • MarkEditMac/Resources/Localizable.xcstrings
    • MarkEditMac/mul.lproj/Main.xcstrings (no changes needed)
    • MarkEditMac/AppShortcuts.xcstrings (no changes needed)
    • FinderExtension/Localizable.xcstrings (no changes needed)
    • PreviewExtension/mul.lproj/Main.xcstrings (no changes needed)
  • Verify the build succeeds (syntax validated)
  • Request code review (passed with no issues)
  • Run security checker (no vulnerabilities found)
  • Fix xcstrings formatting issue (preserve spaces after colons)

Summary

All user-facing strings now use proper curly quotes:

  • 2 apostrophes replaced: Couldn't, You're
  • 5 pairs of double quotes replaced around placeholders
  • Only 1 xcstrings file updated (Localizable.xcstrings), others didn't contain affected strings
  • Original JSON formatting preserved (spaces after colons maintained)
Original prompt

This section details on the original issue you should resolve

<issue_title>Use curly quotes</issue_title>
<issue_description>For user-facing strings only:

  • Search the Localized enum and its extensions
  • Replace both single quotes and double quotes with their curly forms
  • Update corresponding xcstrings files</issue_description>

<agent_instructions>Follow the issue description closely, make no mistake.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 6, 2026 00:11
Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
Copilot AI changed the title [WIP] Update user-facing strings to use curly quotes Replace straight quotes with curly quotes in user-facing strings Feb 6, 2026
Copilot AI requested a review from cyanzhong February 6, 2026 00:14
@cyanzhong
Copy link
Contributor

@copilot You should not be re-formatting the xcstrings, spaces after " should be kept.

Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 6, 2026

@copilot You should not be re-formatting the xcstrings, spaces after " should be kept.

Fixed in 8c79901. The xcstrings files now preserve the original formatting with spaces after colons (:) and only the string keys have been updated to use curly quotes.

@cyanzhong cyanzhong marked this pull request as ready for review February 6, 2026 00:44
@cyanzhong cyanzhong merged commit 3da89b0 into main Feb 6, 2026
2 checks passed
@cyanzhong cyanzhong deleted the copilot/use-curly-quotes branch February 6, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use curly quotes

2 participants