Propagate verify=False from session to requests#387
Propagate verify=False from session to requests#387phinds1 wants to merge 1 commit intoMarketSquare:masterfrom
Conversation
|
@phinds1 would be very useful a test that shows the bug and your PR that fixes the test. |
|
Are there unit tests somewhere? Or integration test framework that could have a broken SSL server added? I didn't add a feature, its just a bug fix, so there should be no more or less test coverage. |
|
An integration test is quite hard to develop in this case, I've on my list. |
|
|
||
| self._capture_output() | ||
|
|
||
| kwargs.update({'verify': session.verify}) |
There was a problem hiding this comment.
This will break session less keywords (session is not defined in this case), and should not be necessary when the session has verify=False
|
I just tested this and it works as expected. |
ref: https://forum.robotframework.org/t/how-to-make-requests-library-ignore-ssl-errors/6790
ref: #386