Status msg, DWIN temp fixes#28269
Open
classicrocker883 wants to merge 26 commits intoMarlinFirmware:bugfix-2.1.xfrom
Open
Status msg, DWIN temp fixes#28269classicrocker883 wants to merge 26 commits intoMarlinFirmware:bugfix-2.1.xfrom
classicrocker883 wants to merge 26 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
Contributor
|
Th UI has always displayed E1, E2 etc while code says E0,E1 etc This is a deliberate design decision as UI users are not programmers (in general) and expect number to start at 1 |
f97c01b to
5c6ac2a
Compare
Member
|
The design of |
14a5fc9 to
30f1ed5
Compare
thinkyhead
reviewed
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a couple small issues in the console/terminal.
It will say
Printing...after heating - (in simulator) using these commands:So the fix is to add a stop timer during first boot / initialization, however it doesnt fully go away after the initial start. it will keep saying this even though it isnt printing after a few more heating commands.
Fix
AUTOTEMP_FACTORresetting value. previously, the default value has no real effect. now it stays unless changedFix having no
PREHEAT_LABELfor M303, Creality, ProUI, JyersUI LCDUpdate
PID_autotunelogic. safeguard zero. dynamic time delay 5000UL for bed/chamber 3000UL for hotend - because hotends heat/cool at a faster rate.Hush warning when using certain Configs (happened when testing with simulator) in lcd/dogm/status_screen_DOGM.cpp, uses correct
u_longinsteadWe could use
PRIu32instead, either way..Requirements
Benefits
Configurations
Related Issues
HAS_MULTI_HOTENDline inTemperature::set_heating_message- temperature.cppPOWER_LOSS_RECOVERYcheck is needed or not inMarlinUI::init- lcd/marlinui.cppAUTOTEMP_FACTORseems to be useless. looks likeM104must use a value withFotherwise withoutFor a value for it it resets to 0.00fixed in this PR