Add support for custom device names #347
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option in the settings menu for the user to specify a custom device name. Empty or entirely whitespace values will be treated as unset. On the ts/vue side, names are stored as string/undefined with normalization of empty/whitespace strings to undefined. On the rust side, names are stored as Option<String>. If a valid custom device name is specified, it will be used in place of the hostname in mdns advertisements. If no device name or an invalid device name is specified, the hostname will be used as a fallback. Fixes Martichou#310.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option in the settings menu for the user to specify a custom device name.
Empty or entirely whitespace values will be treated as unset.
On the ts/vue side, names are stored as string/undefined with normalization of empty/whitespace strings to undefined.
On the rust side, names are stored as Option.
If a valid custom device name is specified, it will be used in place of the hostname in mdns advertisements.
If no device name or an invalid device name is specified, the hostname will be used as a fallback.
Fixes #310