Skip to content

Test enhancement#172

Open
peter279k wants to merge 1 commit intoMasterminds:masterfrom
open-source-contributions:test_enhancement
Open

Test enhancement#172
peter279k wants to merge 1 commit intoMasterminds:masterfrom
open-source-contributions:test_enhancement

Conversation

@peter279k
Copy link

@peter279k peter279k commented Nov 12, 2019 •
edited
Loading

Changed log

  • The PHPUnit fixture setUp method is protected, not public.
  • Removing additional white spaces.
  • Using the assertTrue and assertFalse to assert expected value is true and false.
  • Using the assertInternalType is assert expected value type is string.
  • To avoid logical condition statement inside assertion, using the assertContains to assert the expected sub string contains on specific string result.

goetas
goetas requested changes Nov 14, 2019
View reviewed changes
Copy link
Member

@goetas goetas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good except one small thing.

test/HTML5/Serializer/OutputRulesTest.php
$contents = $this->html5->saveHTML($dom);

$this->assertTrue(false !== strpos($contents, '<script id="template" type="x-tmpl-mustache">
$this->assertContains('<script id="template" type="x-tmpl-mustache">
Copy link
Member

@goetas goetas Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be assertStringContainsString (see https://phpunit.readthedocs.io/en/8.4/assertions.html#assertstringcontainsstring).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goetas goetas goetas requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peter279k @goetas