Support render PHP8.4 \Dom\HTMLDocument#257
Open
asika32764 wants to merge 4 commits intoMasterminds:masterfrom
Open
Support render PHP8.4 \Dom\HTMLDocument#257asika32764 wants to merge 4 commits intoMasterminds:masterfrom
asika32764 wants to merge 4 commits intoMasterminds:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple fix for rendering PHP 8.4 HTMLDocument, this PR dosen't support the parsing of new DOM.
Why
Currently, native PHP HTMLDocument still contains some rendering difference from this library, for instance, PHP rendered the boolean attributes as
required=""however this library isrequired.This PR make sure the new DOM can be rendered as same as the old DOM which is rendered by this library.