-
Notifications
You must be signed in to change notification settings - Fork 224
feat: decouple model download from UI with background service #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aisraelov
wants to merge
6
commits into
dev
Choose a base branch
from
stt-model-dl-improve
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Zustand store (modelDownload.ts) for persistent download state - Add singleton service (modelDownloadService.ts) to orchestrate downloads - Add system notifications (modelDownloadNotifications.ts) for progress - Add ModelDownloadEffect to initialize service at app startup - Update transcription.tsx to use store instead of local state - Update ModelSelector with cancel support and state props - Downloads now persist across navigation and show in notifications Also fix lint errors: - Add eslint-disable for import/no-unresolved (MaterialIcons, SVGs) - Fix unused variables ($styles, $headerText, props) - Fix StyleSheet import restrictions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🕶️ ASG Client Build⏳ Waiting for build... 🔀 Test Locallygh pr checkout 1755 |
Deploying mentra-live-ota-site with
|
| Latest commit: |
4042737
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad74447b.mentra-live-ota-site.pages.dev |
| Branch Preview URL: | https://stt-model-dl-improve.mentra-live-ota-site.pages.dev |
Deploying mentra-store-dev with
|
| Latest commit: |
4042737
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e61737c.augmentos-appstore-2.pages.dev |
| Branch Preview URL: | https://stt-model-dl-improve.augmentos-appstore-2.pages.dev |
Deploying dev-augmentos-console with
|
| Latest commit: |
4042737
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a88f40b4.dev-augmentos-console.pages.dev |
| Branch Preview URL: | https://stt-model-dl-improve.dev-augmentos-console.pages.dev |
Deploying prod-augmentos-account with
|
| Latest commit: |
4042737
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e8a0eb59.augmentos-e84.pages.dev |
| Branch Preview URL: | https://stt-model-dl-improve.augmentos-e84.pages.dev |
Accepted dev versions of conflicted files to bring PR up to date. Removed old glasseswifisetup files (moved to wifi/). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Removed duplicate import from @/utils/useAppTheme - keeping the one from @/contexts/ThemeContext which is the canonical location. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix lint errors:
🤖 Generated with Claude Code