Skip to content

Conversation

@bgravenorst
Copy link
Contributor

@bgravenorst bgravenorst commented Feb 3, 2026

Description

Test parser for base/ethereum.


Note

Medium Risk
Broad documentation refactor to auto-render many method pages via ParserOpenRPC, so spec/renderer issues can affect large sections of the reference. Also introduces new Base/Ethereum request URL handling in the interactive parser (and references ETHEREUM_PROD_URL, which appears undefined), which could break builds or requests if misconfigured.

Overview
Migrates Base and Ethereum JSON-RPC method docs from hand-written MDX (partials, examples, and custom notes) to a single ParserOpenRPC embed per page, with titles/TOC hidden so the parser drives the layout.

Extends ParserOpenRPC to support src="local" for Base and Ethereum by loading local OpenRPC specs and improving server URL discovery (checks both servers and info.servers). It also selects a per-network default Infura request base URL (Base/Ethereum/Linea) when the spec doesn’t provide one.

Updates plugin-json-rpc to add base and ethereum to NETWORK_NAMES, and adds Base Infura URL constants in constants.ts.

Written by Cursor Bugbot for commit 84a74c4. This will update automatically on new commits. Configure here.

Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
@bgravenorst bgravenorst requested review from a team as code owners February 3, 2026 03:22
@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
metamask-docs Ready Ready Preview, Comment Feb 3, 2026 3:27am

Request Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

export const LINEA_DEV_URL = 'https://linea-mainnet.dev.infura.org'
export const LINEA_REQUEST_URL = LINEA_PROD_URL
export const BASE_PROD_URL = 'https://base-mainnet.infura.io'
export const BASE_REQUEST_URL = BASE_PROD_URL
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused export BASE_REQUEST_URL defined but never used

Low Severity

BASE_REQUEST_URL is exported but never imported or used anywhere in the codebase. The component imports BASE_PROD_URL directly. Unlike LINEA_REQUEST_URL which is actually used, this export is dead code.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants