-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat(Snaps): Change Snap export tracking approach #31553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🫰 @MetaMask/snaps-devs
|
42a4287 to
de35e5f
Compare
Collaborator
Builds ready [0e305f4]
UI Startup Metrics (1225 ± 66 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Merged
7 tasks
Collaborator
Builds ready [d9d1973]
UI Startup Metrics (1212 ± 62 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
d9d1973 to
78ecd22
Compare
Collaborator
Builds ready [78ecd22]
UI Startup Metrics (1236 ± 65 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
7716eac to
7c83edf
Compare
7c83edf to
51025f3
Compare
Collaborator
Builds ready [51025f3]
UI Startup Metrics (1215 ± 70 ms)
Benchmark value 337 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 0ms | Sum of p95 exceeds: 10ms Sum of all benchmark exceeds: 10ms Bundle size diffs [🚀 Bundle size reduced!]
|
github-merge-queue bot
pushed a commit
to MetaMask/snaps
that referenced
this pull request
May 5, 2025
This PR moves MetaMetrics tracking of Snap export usage to Snap Controller. Related issue: #3259 Extension integration PR: MetaMask/metamask-extension#31553 Mobile integration PR: MetaMask/metamask-mobile#14428
Fix lint issues Fix unit test Return changes after conflict resolve (rebase) Revert unwanted controller changes
51025f3 to
b44273c
Compare
Collaborator
Builds ready [b44273c]
UI Startup Metrics (1227 ± 64 ms)
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1069 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 1455 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1294 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1294 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 1276 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 1770 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1569 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1569 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 1549 exceeds gate value 1475 for firefox browserify home p95 loadScripts Sum of mean exceeds: 215ms | Sum of p95 exceeds: 339ms Sum of all benchmark exceeds: 554ms Bundle size diffs [🚀 Bundle size reduced!]
|
Mrtenz
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
May 13, 2025
…14428) ## **Description** This PR adds MetaMetrics tracking hook to Snap controller init. This way we delegate Snap export tracking to Snap controller. ## **Related issues** Related PR: MetaMask/snaps#3281 MetaMask/metamask-extension#31553 ## **Notes** - Requires Snaps release. - Snaps PR: MetaMask/snaps#3281 - Targets Snaps release when ready. ## **Manual testing steps** 1. TBD ## **Screenshots/Recordings** ### **Before** n/a ### **After** n/a ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Mrtenz
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
May 13, 2025
…14428) ## **Description** This PR adds MetaMetrics tracking hook to Snap controller init. This way we delegate Snap export tracking to Snap controller. ## **Related issues** Related PR: MetaMask/snaps#3281 MetaMask/metamask-extension#31553 ## **Notes** - Requires Snaps release. - Snaps PR: MetaMask/snaps#3281 - Targets Snaps release when ready. ## **Manual testing steps** 1. TBD ## **Screenshots/Recordings** ### **Before** n/a ### **After** n/a ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Mrtenz
approved these changes
May 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
team-snaps-platform-deprecated
DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the next step in moving Snap export tracking away from the extension and transferring its functionality and responsibility to Snap Controller.
Notes
Related issues
Fixes: MetaMask/snaps#3259
Manual testing steps
Screenshots/Recordings
Before
n/a
After
n/a
Pre-merge author checklist
Pre-merge reviewer checklist