feat(ocap-kernel): Add kernel syscall 'revoke'#551
Draft
Conversation
grypez
force-pushed
the
grypez/revoke-syscall
branch
from
e985dd6 to
52f9b80
Compare
sirtimid
reviewed
Jun 26, 2025
Contributor
sirtimid
left a comment
sirtimid
left a comment
There was a problem hiding this comment.
Both makeOcapUrl and makeRovoker are synchronous, which was the argument against using a device. I wonder could we pursue that?
Contributor
Author
With kernel service objects #563 these user-space syscalls are E-addressable from the vats that rely on them. Will update this soon to reflect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
This PR prototypes a user code authority to effect a kernel syscall which accepts a remotable object argument. This solution mostly bypasses liveslots, extracting vrefs by hacking apart the return values of the only-exported-for-testing marshaller; this probably messes up liveslots's book keeping efforts.