Skip to content

Fix #145: Remove encodePermissionContexts and decodePermissionContexts functions from public interface #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patchy-the-bot wants to merge 5 commits into
base: main
Choose a base branch
from
+12 −13
Open

Fix #145: Remove encodePermissionContexts and decodePermissionContexts functions from public interface #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5934f27
Remove encodePermissionContexts and decodePermissionContexts wrappers
Feb 11, 2026
0b415bc
Remove remaining references to encodePermissionContexts
Feb 11, 2026
518729c
Fix linting errors
jeffsmale90 Feb 12, 2026
e3e6d77
Fix e2e tests that relied on the removed functino
jeffsmale90 Feb 12, 2026
004153e
Merge branch 'main' into patchy/issue-145-remove-encodepermissioncontext
jeffsmale90 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/delegator-e2e/test/delegateAndRedeem.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
type PartialSignature,
} from '@metamask/smart-accounts-kit';
import {
encodePermissionContexts,
encodeDelegations,
encodeExecutionCalldatas,
} from '@metamask/smart-accounts-kit/utils';
import { generatePrivateKey, privateKeyToAccount } from 'viem/accounts';
Expand Down Expand Up @@ -123,7 +123,7 @@ test('maincase: Bob increments the counter with a delegation from Alice', async
abi: bobSmartAccount.abi,
functionName: 'redeemDelegations',
args: [
encodePermissionContexts([[signedDelegation]]),
[encodeDelegations([signedDelegation])],
[ExecutionMode.SingleDefault],
encodeExecutionCalldatas([[execution]]),
],
Expand Down Expand Up @@ -232,7 +232,7 @@ test("Bob attempts to increment the counter with a delegation from Alice that do
abi: bobSmartAccount.abi,
functionName: 'redeemDelegations',
args: [
encodePermissionContexts([[signedDelegation]]),
[encodeDelegations([signedDelegation])],
[ExecutionMode.SingleDefault],
encodeExecutionCalldatas([[execution]]),
],
Expand Down Expand Up @@ -335,7 +335,7 @@ test('Bob increments the counter with a delegation from a multisig account', asy
abi: bobSmartAccount.abi,
functionName: 'redeemDelegations',
args: [
encodePermissionContexts([[signedDelegation]]),
[encodeDelegations([signedDelegation])],
[ExecutionMode.SingleDefault],
encodeExecutionCalldatas([[execution]]),
],
Expand Down Expand Up @@ -366,4 +366,4 @@ test('Bob increments the counter with a delegation from a multisig account', asy

const countAfter = await counterContract.read.count();
expect(countAfter, 'Expected final count to have incremented').toEqual(1n);
});
});
6 changes: 3 additions & 3 deletions ...smart-accounts-kit/src/DelegationFramework/DelegationManager/methods/redeemDelegations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { Address, Client } from 'viem';
import { encodeFunctionData } from 'viem';
import { simulateContract, writeContract } from 'viem/actions';

import { encodePermissionContexts } from '../../../delegation';
import { encodeDelegations } from '../../../delegation';
import { encodeExecutionCalldatas } from '../../../executions';
import type { ExecutionMode, ExecutionStruct } from '../../../executions';
import type { Delegation } from '../../../types';
Expand Down Expand Up @@ -37,7 +37,7 @@ export const simulate = async ({
abi: DelegationManager,
functionName: 'redeemDelegations',
args: [
encodePermissionContexts(delegations),
delegations.map((delegationChain) => encodeDelegations(delegationChain)),
modes,
encodeExecutionCalldatas(executions),
],
Expand Down Expand Up @@ -71,7 +71,7 @@ export const encode = ({
abi: DelegationManager,
functionName: 'redeemDelegations',
args: [
encodePermissionContexts(delegations),
delegations.map((delegationChain) => encodeDelegations(delegationChain)),
modes,
encodeExecutionCalldatas(executions),
],
Expand Down
2 changes: 0 additions & 2 deletions packages/smart-accounts-kit/src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ export {
decodeDelegation,
toDelegationStruct,
toDelegation,
encodePermissionContexts,
decodePermissionContexts,
DELEGATION_ARRAY_ABI_TYPE,
DELEGATION_ABI_TYPE,
DELEGATION_ABI_TYPE_COMPONENTS,
Expand Down
7 changes: 4 additions & 3 deletions packages/smart-accounts-kit/src/write.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { SimpleFactory, DelegationManager } from '@metamask/delegation-abis';
import type { Address, Chain, Hex, PublicClient, WalletClient } from 'viem';

import { encodePermissionContexts } from './delegation';
import { encodeDelegations } from './delegation';
import type { ExecutionStruct, ExecutionMode } from './executions';
import { encodeExecutionCalldatas } from './executions';
import type { Delegation, ContractMetaData, Redemption } from './types';
Expand Down Expand Up @@ -62,8 +62,9 @@ export const redeemDelegations = async (
executionModes.push(redemption.mode);
});

const encodedPermissionContexts =
encodePermissionContexts(permissionContexts);
const encodedPermissionContexts = permissionContexts.map((delegationChain) =>
encodeDelegations(delegationChain),
);
const executionCalldatas = encodeExecutionCalldatas(executionsBatch);

const { request } = await publicClient.simulateContract({
Expand Down
Loading